-
Notifications
You must be signed in to change notification settings - Fork 260
fix(NODE-6764): incorrect negative bigint handling #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
38d8b75
fix incorrect bigint handling
W-A-James 9686f2a
update bigint tests
W-A-James fdeb012
update format script
W-A-James cdaec88
format
W-A-James d64860e
move tests to deserialize
W-A-James 69b7304
move tests out of loop
W-A-James 1a70226
change bit math instead of using BigInt.asIntN
W-A-James File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,6 +105,39 @@ describe('BSON BigInt support', function () { | |
|
||
it(description, test); | ||
} | ||
|
||
describe('edge case tests', function () { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just a little nit. Instead of just calling these edge case tests can we better describe what we are testing here? I'd personally prefer individual |
||
const tests = [ | ||
{ | ||
expectedResult: { a: -(2n ** 63n) }, | ||
input: Buffer.from('10000000126100000000000000008000', 'hex') | ||
}, | ||
{ | ||
expectedResult: { a: -1n }, | ||
input: Buffer.from('10000000126100FFFFFFFFFFFFFFFF00', 'hex') | ||
}, | ||
{ | ||
expectedResult: { a: 0n }, | ||
input: Buffer.from('10000000126100000000000000000000', 'hex') | ||
}, | ||
{ | ||
expectedResult: { a: 1n }, | ||
input: Buffer.from('10000000126100010000000000000000', 'hex') | ||
}, | ||
{ | ||
expectedResult: { a: 2n ** 63n - 1n }, | ||
input: Buffer.from('10000000126100FFFFFFFFFFFFFF7F00', 'hex') | ||
} | ||
]; | ||
|
||
for (const test of tests) { | ||
it(`correctly deserializes the bson document encoded in ${test.input.toString('hex')}`, function () { | ||
expect(BSON.deserialize(test.input, { useBigInt64: true })).to.deep.equal( | ||
test.expectedResult | ||
); | ||
}); | ||
} | ||
}); | ||
}); | ||
|
||
describe('BSON.serialize()', function () { | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.