-
Notifications
You must be signed in to change notification settings - Fork 260
feat(NODE-4713)!: modernize bundling #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a6a6d6f
feat!(NODE-4713): modernize bundling
nbbeeken eae05e5
docs: add description of rollup reasoning
nbbeeken 61894b3
style: camel case
nbbeeken c49da0d
fixup require to use protocol import
nbbeeken 8f4deab
chore: use explicit null proto syntax
nbbeeken 20b23a9
Merge branch 'main' into NODE-4713-bundling
durran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
etc/rollup/rollup-plugin-require-rewriter/require_rewriter.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
import MagicString from 'magic-string'; | ||
|
||
const CRYPTO_IMPORT_ESM_SRC = `const nodejsRandomBytes = await (async () => { | ||
try { | ||
return (await import('node:crypto')).randomBytes;`; | ||
|
||
export class RequireRewriter { | ||
/** | ||
* Take the compiled source code input; types are expected to already have been removed | ||
* Look for the function that depends on crypto, replace it with a top-level await | ||
* and dynamic import for the node:crypto module. | ||
* | ||
* @param {string} code - source code of the module being transformed | ||
* @param {string} id - module id (usually the source file name) | ||
* @returns {{ code: string; map: import('magic-string').SourceMap }} | ||
*/ | ||
transform(code, id) { | ||
if (!id.includes('node_byte_utils')) { | ||
return; | ||
} | ||
if (!code.includes('const nodejsRandomBytes')) { | ||
throw new Error(`Unexpected! 'const nodejsRandomBytes' is missing from ${id}`); | ||
} | ||
|
||
const start = code.indexOf('const nodejsRandomBytes'); | ||
const endString = `return require('crypto').randomBytes;`; | ||
const end = code.indexOf(endString) + endString.length; | ||
|
||
if (start < 0 || end < 0) { | ||
throw new Error( | ||
`Unexpected! 'const nodejsRandomBytes' or 'return require('crypto').randomBytes;' not found` | ||
); | ||
} | ||
|
||
// MagicString lets us edit the source code and still generate an accurate source map | ||
const magicString = new MagicString(code); | ||
magicString.overwrite(start, end, CRYPTO_IMPORT_ESM_SRC); | ||
|
||
return { | ||
code: magicString.toString(), | ||
map: magicString.generateMap({ hires: true }) | ||
}; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.