Skip to content

Conversation

@ACK-J
Copy link

@ACK-J ACK-J commented Jul 21, 2023

Added /api/transaction/private/<TXID postfix hash> to the block explorer API so users can request transaction information in a private way.

Related to #284

@ACK-J
Copy link
Author

ACK-J commented Jul 21, 2023

k-anonymity for transactions now works however performance needs to improve. It takes 35 seconds to return 825 transactions on a somewhat resource limited virtual machine. @moneroexamples do you have any ideas? Maybe batching transactions?

@moneroexamples
Copy link
Owner

Thanks. Sorry, at the moment I do not know how to improve its performance.

@ACK-J
Copy link
Author

ACK-J commented Jul 27, 2023

I made some performance improvements which got the time down to 3 seconds to request 647 transactions. However, the use of get_transactions() requires the node RPC not be in restricted mode, or else only 100 transactions can be returned.

@ACK-J
Copy link
Author

ACK-J commented Jul 30, 2023

I made some additional performance improvements which got the time down to 0.5 seconds to request 647 transactions and 16 seconds for 10,000 txs. Adding threading helped a lot when > 1000 transactions are requested. These numbers are also from a low resource VM, I will test it on a high performance server soon. I suggest you run the daemon with the following flags to prevent LMDB max reader errors.
./monerod --stagenet --max-concurrency 60

@jeffro256
Copy link
Contributor

Can you pull out the typo changes into a separate PR, please?

Copy link

@melissamforbs melissamforbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants