Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rework of #1084 using a freshly-compiled
zicandzdumpfrom the IANA source. There turned out to be two separate bugs at play with the initial data build:zdumpwas previously very old and only handled 32-bit data, which this project's build process could catch and warn about. The latest Sonoma releases have updated tozdumpfrom2022gwhich works just enough to look like it's fine.zicandzdumphad bugs that inadvertently dropped some transitions from a small number of zones. This was fixed in2023d, which is why zones likeAmerica/Ciudad_Juareznow have more data without the source files changing. (It only affects transitions after the year 2400, so not a big deal.)zdump@2022gcompilingdata@2023don macOS, which look like it worked properly, but was subtly wrong. Zones likeAmerica/Godthabdropped any transitions after 2023, which was definitely not correct. Manually compilingzdumpfrom the2023dsource fixed that issue in this PR.Interestingly, the new (previously-missing) data for
America/Ciudad_Juarezalso contains some buggy transitions right after the previous data cut-off. There's possibly another bug lurking in tzcode somewhere.The PR contains the following changes from tzdb (edited to remove details irrelevant to this project):
Closes #1083