Skip to content

Conversation

@senivam
Copy link

@senivam senivam commented Oct 1, 2025

No description provided.

@slachiewicz slachiewicz requested a review from Copilot October 5, 2025 19:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for configurable revision variable names in the flatten-maven-plugin's CI-friendly version resolution. Instead of being hardcoded to use ${revision}, the plugin now allows users to specify a custom variable name through the revisionVariableName parameter.

Key changes:

  • Added a new configurable parameter revisionVariableName with default value "revision"
  • Updated interpolation logic to use the configurable variable pattern instead of hardcoded ${revision}
  • Added comprehensive test coverage for the new functionality

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/main/java/org/codehaus/mojo/flatten/FlattenMojo.java Added revisionVariableName parameter and integration with interpolator
src/main/java/org/codehaus/mojo/flatten/cifriendly/CiModelInterpolator.java Updated to accept and use configurable revision variable pattern
src/main/java/org/codehaus/mojo/flatten/cifriendly/CiInterpolatorImpl.java Modified interpolation logic to use configurable variable pattern
src/test/java/org/codehaus/mojo/flatten/DifferentRevisionVariableNameTest.java Test case verifying custom revision variable name functionality
src/test/resources/differentrevisionvariablename/pom.xml Test POM using custom revision variable name
src/test/resources/differentrevisionvariablename/expected-flattened-pom.xml Expected output for test case

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@senivam
Copy link
Author

senivam commented Oct 6, 2025

@slachiewicz, thank you for the review. As soon as the comment came after the approval, the question is if it should be considered?

@slachiewicz
Copy link
Member

I thought that there was a typo but later found logic that adds ${ } around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants