Resource subscribe should be true if handler provided #676
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix #656 I believe. |
stephentoub
reviewed
Aug 5, 2025
PederHP
changed the title
…t of handlers present.
…t of handlers present.
mikekistler
reviewed
Sep 8, 2025
| resourcesCapability.Subscribe = true; | ||
| } | ||
| if (SubscribeToResourcesHandler is not null || UnsubscribeFromResourcesHandler is not null) | ||
| { |
There was a problem hiding this comment.
I think this will fix the deref of a possibly null reference:
Suggested change
| { | |
| { | |
| resourcesCapability ??= new(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is an old todo. Resource subscription is now supported and the handler is registered in the same file.
How Has This Been Tested?
Not yet, soon.
Breaking Changes
Types of changes
Checklist
Additional context