Skip to content

3370: Add support for comment lines in "mocha.opts" #3375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bamieh merged 2 commits into from
May 8, 2018
Merged

3370: Add support for comment lines in "mocha.opts" #3375

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9745f1
feat(bin/options.js): Add support for comment lines in "mocha.opts"
plroebuck May 3, 2018
ddd15ed
docs(docs/index.md): Update "mocha.opts" documentation
plroebuck May 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bin/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ function getOptions() {
try {
const opts = fs
.readFileSync(optsPath, 'utf8')
.replace(/^#.*$/gm, '')
.replace(/\\\s/g, '%20')
.split(/\s/)
.filter(Boolean)
Expand Down
1 change: 1 addition & 0 deletions test/integration/regression.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ describe('regressions', function() {
var processArgv = process.argv.join('');
var mochaOpts = fs
.readFileSync(path.join(__dirname, '..', 'mocha.opts'), 'utf-8')
.replace(/^#.*$/gm, '')
.split(/[\s]+/)
.join('');
assert.notEqual(
Expand Down
5 changes: 5 additions & 0 deletions test/mocha.opts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
###
### mocha.opts
###

--require ./test/setup
--ui bdd
--globals okGlobalA,okGlobalB
--globals okGlobalC
--globals callback*
--timeout 200