update docs for the glob #3217
Merged
update docs for the glob #3217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Love it! Thank you for contributing! |
harrysarson
reviewed
Jan 23, 2018
| ## The `test/` Directory | ||
|
|
||
| By default, `mocha` looks for the glob `./test/*.js` and `./test/*.coffee`, so you may want to put your tests in `test/` folder. | ||
| By default, `mocha` looks for the glob `./test/*.js`, so you may want to put your tests in `test/` folder. If you want to include sub directories, use `--recursive`, because of `./test/*.js` is only matched with files which in the first depth of `test` directory and `./test/**/*.js` is only matched with files which in the second depth of `test` directory. |
Contributor
There was a problem hiding this comment.
./test/**/*.js
is only matched with files which in the second depth oftest` directory
Is this true? I though '/**/' matches zero or more directory levels.
Contributor
There was a problem hiding this comment.
From https://www.npmjs.com/package/glob
** If a "globstar" is alone in a path portion, then it matches zero or more directories and subdirectories searching for matches. It does not crawl symlinked directories.
Contributor
There was a problem hiding this comment.
This depends on if you pass a glob pattern as a string or use shell expansion. Shell expansion will only expand to the second level, and actually exactly the second level, not the first one, so that is also a bit confusing to many
boneskull
added
semver-patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
.coffeedoesn't supported now. And I enhance the explanation of glob.Please check my English sentences.
Alternate Designs
N/A
Why should this be in core?
.coffeedoesn't supported now.Benefits
Users don't confuse anymore.
Possible Drawbacks
N/A
Applicable issues
Close #3132
Close #3098