Added Node.js 9 support, removed Node.js 7 #3160
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boneskull
suggested changes
Dec 31, 2017
Member
boneskull
left a comment
boneskull
left a comment
There was a problem hiding this comment.
thanks! just a tweak necessary
| - node_js: '9' | ||
| env: TARGET=test-node COVERAGE=true | ||
| - node_js: '8' | ||
| env: TARGET=test-node COVERAGE=true |
Member
There was a problem hiding this comment.
we only need to have COVERAGE=true on one of these, so please remove it from line 21.
boneskull
added
qa
semver-patch
Contributor
Author
|
I wasn't able to edit this PR, so i make a new one: #3185 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3127
I don't know if we should also add node.js 9 for the browser test.