Skip to content

introduce package-lock.json; closes #3025 #3026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boneskull merged 2 commits into from
Dec 10, 2017
Merged

introduce package-lock.json; closes #3025 #3026

boneskull merged 2 commits into from
Dec 10, 2017

Conversation

@boneskull
Copy link
Member

@boneskull boneskull commented Sep 28, 2017

  • update .travis.yml to use npm@5 caching where available
  • remove .npmrc (now unused)
  • remove package-lock.json from .gitignore

@boneskull boneskull added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Sep 28, 2017
@boneskull boneskull added this to the v4.0.0 milestone Sep 28, 2017
@boneskull boneskull self-assigned this Sep 28, 2017
@boneskull boneskull changed the title introduce package-lock.json; closes introduce package-lock.json; closes #3025 Sep 28, 2017
@boneskull boneskull removed this from the v4.0.0 milestone Sep 28, 2017
@boneskull
Copy link
Member Author

boneskull commented Sep 28, 2017

we'll deal w/ this later.

@sukrosono
Copy link

sukrosono commented Nov 27, 2017

ping @boneskull, since you notify that you are back now. 😄

@boneskull
Copy link
Member Author

boneskull commented Nov 27, 2017

@brutalcrozt do you need this for something?

@sukrosono
Copy link

sukrosono commented Nov 28, 2017

No at all, it's seem simple. Just hoping number of open PR, and issue got decreased.

@boneskull
introduce package-lock.json; closes #3025
e68d69e 
- update `.travis.yml` to use npm@5 caching where available
- remove `.npmrc` (now unused)
- remove `package-lock.json` from `.gitignore`
@coveralls
Copy link

coveralls commented Dec 9, 2017

Coverage Status

Coverage remained the same at 89.95% when pulling a11033b on issue/3025 into 743c830 on master.

@coveralls
Copy link

coveralls commented Dec 9, 2017

Coverage Status

Coverage remained the same at 89.95% when pulling e68d69e on issue/3025 into 3200d41 on master.

@boneskull boneskull merged commit 5fbbce9 into master Dec 10, 2017
@boneskull boneskull deleted the issue/3025 branch December 10, 2017 05:41
@boneskull boneskull removed their assignment Dec 12, 2017
@boneskull boneskull added this to the v4.1.0 milestone Dec 29, 2017
@boneskull boneskull added the type: chore generally involving deps, tooling, configuration, etc. label Dec 29, 2017
@renovate renovate bot mentioned this pull request Feb 14, 2018
Merged
sgilroy pushed a commit to TwineHealth/mocha that referenced this pull request Feb 27, 2019
@boneskull
introduce package-lock.json; closes mochajs#3025 (mochajs#3026)
6d3d908 
- update `.travis.yml` to use npm@5 caching where available
- remove `.npmrc` (now unused)
- remove `package-lock.json` from `.gitignore`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markowsiak markowsiak Awaiting requested review from markowsiak

@ScottFreeCode ScottFreeCode Awaiting requested review from ScottFreeCode

Assignees

No one assigned

Labels

semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.

Projects

None yet

Milestone

v4.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@boneskull @sukrosono @coveralls