Skip to content

Increase tests coverage for nyan reporter to 100% #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Munter merged 6 commits into from
Jan 31, 2017
Merged

Increase tests coverage for nyan reporter to 100% #2695

Munter merged 6 commits into from
Jan 31, 2017

Conversation

@craigtaub
Copy link
Contributor

@craigtaub craigtaub commented Jan 30, 2017 •
edited
Loading

I am adding 20 new test scenarios for the nyan reporter (its quite a beefy reporter, added to the 4 that were already there). It should now be fully covered.
AppVeyor does not seem to have TTY support so tests around that.

Coverage diff:
screen shot 2017-01-30 at 10 37 54
screen shot 2017-01-30 at 23 09 32

Hope it helps

@craigtaub
Copy link
Contributor Author

craigtaub commented Jan 30, 2017 •
edited
Loading

Issue with TTY on CI box. Will investigate.

@coveralls
Copy link

coveralls commented Jan 30, 2017

Coverage Status

Coverage increased (+2.1%) to 81.253% when pulling 5c904e0 on craigtaub:nyanReporterSpec into 503627c on mochajs:master.

@coveralls
Copy link

coveralls commented Jan 31, 2017

Coverage Status

Coverage increased (+3.0%) to 82.103% when pulling 2b4eb7c on craigtaub:nyanReporterSpec into 503627c on mochajs:master.

@coveralls
Copy link

coveralls commented Jan 31, 2017

Coverage Status

Coverage increased (+3.0%) to 82.103% when pulling 443bd0c on craigtaub:nyanReporterSpec into 503627c on mochajs:master.

@coveralls
Copy link

coveralls commented Jan 31, 2017

Coverage Status

Coverage increased (+3.0%) to 82.103% when pulling 00d40c9 on craigtaub:nyanReporterSpec into 503627c on mochajs:master.

@Munter
Copy link
Contributor

Munter commented Jan 31, 2017

Awesome! Thank you for the contribution

@Munter Munter merged commit bc06b85 into mochajs:master Jan 31, 2017
@coveralls
Copy link

coveralls commented Jan 31, 2017

Coverage Status

Coverage increased (+3.0%) to 82.103% when pulling 94f2023 on craigtaub:nyanReporterSpec into 503627c on mochajs:master.

@craigtaub craigtaub deleted the nyanReporterSpec branch January 31, 2017 14:44
@renovate renovate bot mentioned this pull request Jul 7, 2017
Merged
sgilroy pushed a commit to TwineHealth/mocha that referenced this pull request Feb 27, 2019
@Munter
Merge pull request mochajs#2695 from craigtaub/nyanReporterSpec
7f533ae 
Increase tests coverage for nyan reporter to 100%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@craigtaub @coveralls @Munter