Skip to content

normalize setters and getters #3058

@boneskull

Description

@boneskull

The main classes (Runnable, Test, Context, Suite, Mocha, etc.) have these setter/getter functions, e.g. Runnable#timeout(). Not all of these, however, implement the "getter" part, where it's supposed to just return the value if it receives no arguments.

Furthermore, there are some methods that might check if the first argument is undefined; they need to check length of arguments instead, because undefined or void 0 is a valid argument.

Metadata

Metadata

Assignees

No one assigned

    Labels

    semver-minorimplementation requires increase of "minor" version number; "features"status: accepting prsMocha can use your help with this one!type: choregenerally involving deps, tooling, configuration, etc.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions