attempt to fix CI #612

djs55 · 2017-09-28T13:30:36Z

Using Xcode 8.3 in circle.yml should hopefully fix the error:

carthage: A full installation of Xcode.app 8.3 is required to compile this software.
Installing just the Command Line Tools is not sufficient.
Xcode can be installed from the App Store.
Error: An unsatisfied requirement failed this build.

Removing one of the references to the version module in bridge/github should fix the error:

Multiple rules generated for _build/default/bridge/github/version.o

Signed-off-by: David Scott [email protected]

This should fix the error: > carthage: A full installation of Xcode.app 8.3 is required to compile this software. > Installing just the Command Line Tools is not sufficient. > Xcode can be installed from the App Store. > Error: An unsatisfied requirement failed this build. Signed-off-by: David Scott <[email protected]>

samoht · 2017-09-28T14:26:18Z

I have pushed more CI fixes directly to your branch. Let's make this green :-)

talex5 · 2017-09-28T14:29:28Z

Makefile

@@ -23,8 +23,7 @@ depends:
 	  datakit-ci datakit-bridge-github datakit-bridge-local-git -y

 datakit:
-	$(BUILD) -n datakit
-	$(RUNTEST) test/datakit
+	$(BUILD) -p datakit


Why did this go? Are we testing it elsewhere?

We are not testing this. And jbuilder -n datakit just says that -n is not a valid option.

This hopefully fixes: > Processing 1/1: [depext: make]-> installed depext.1.0.5 > Done. > Fatal error: exception # opam-version 1.2.2 > # os darwin > opam: "execvpe" failed on opam-depext: No such file or directory > > opam install depext && opam depext osx-fsevents datakit returned exit code 2 Signed-off-by: David Scott <[email protected]>

This could be caused by missing environment variables during the build, hence adding another `opam config exec --` Signed-off-by: David Scott <[email protected]>

Signed-off-by: Thomas Gazagnaire <[email protected]>

samoht · 2017-11-16T12:17:50Z

I have fixed the Dockerfiles and updated everything to use the latest version. Not sure why appveyor and CircleCI are complaining, need to have a closer look.

Signed-off-by: Thomas Gazagnaire <[email protected]>

samoht · 2017-11-17T14:57:04Z

I've bumped appveyor and CircleCI to 4.05, hopefully this will fix the last issues.

samoht · 2017-11-18T10:00:30Z

The appveyor built is blocked on:

datakit -> hvsock >= 0.8.1 -> duration -> alcotest < 0.8.0

which should be solved once ocaml/opam-repository#10770 is updated to the windows repository.

thaJeztah · 2017-11-18T10:08:25Z

Dockerfile

    opam update -u

 ENV OPAMERRLOGLEN=0 OPAMYES=1
-RUN sudo apk add tzdata aspcud gmp-dev perl
+RUN sudo apk update && sudo apk add tzdata aspcud gmp-dev perl


apk add --no-cache should work as well?

@thaJeztah

Thanks to @thaJeztah for the tip Signed-off-by: Thomas Gazagnaire <[email protected]>

samoht · 2017-11-20T11:24:39Z

@talex5 would it be possible to remove the datakit-ci tests (as they are now tested with the main Dockerfile.ci) and to remove the check for the client library on 4.03 (or to use an image with opam2 instead of opam1)?

talex5 · 2017-11-20T12:00:39Z

Just testing it now...

talex5 · 2017-11-20T12:14:38Z

@Samoth: I've pushed a fix to https://github.com/talex5/datakit/tree/fix-ci and deployed it.

samoht · 2017-11-20T12:44:11Z

@talex5 Thanks! Now all seems to be green apart the windows builds as we are waiting for https://github.com/fdopen/opam-repository-mingw to be updated.

opam pin <path> now pins all the available packages in one go (yay). Signed-off-by: Thomas Gazagnaire <[email protected]>

- datakit-ci tests are now done as part of the build - don't check that the client still works on OCaml 4.03 Requested by Thomas Gazagnaire.

samoht · 2017-11-21T09:03:51Z

Finally all green! Merging.

@samoht

CHANGES: - all: update to latest version of alcotest, conduit, session, ocaml-github, ocaml-github-hooks and cohttp (moby/datakit#612, @samoht and @djs55) - github: make `User.t` abstract (moby/datakit#594, @samoht) - github: turn `Webhook.events` into a promise (moby/datakit#598, @samoht) - github: add a `Comment` module to model PR and issue comments (moby/datakit#595, @samoht) - github: change `PR.owner` to be of type `User.t` (moby/datakit#599, @samoht) - github-bridge: add the ability to sync PR's coments (moby/datakit#595, @samoht) - go-client: handle large values when reading / writing in 9db (moby/datakit#292, @simonferquel) - go-client: fix the handling of defaults over upgrade (moby/datakit#605, @djs55) - go-client: improve transaction API (moby/datakit#606, @djs55)

@samoht

CHANGES: - all: update to latest version of alcotest, conduit, session, ocaml-github, ocaml-github-hooks and cohttp (moby/datakit#612, @samoht and @djs55) - github: make `User.t` abstract (moby/datakit#594, @samoht) - github: turn `Webhook.events` into a promise (moby/datakit#598, @samoht) - github: add a `Comment` module to model PR and issue comments (moby/datakit#595, @samoht) - github: change `PR.owner` to be of type `User.t` (moby/datakit#599, @samoht) - github-bridge: add the ability to sync PR's coments (moby/datakit#595, @samoht) - go-client: handle large values when reading / writing in 9db (moby/datakit#292, @simonferquel) - go-client: fix the handling of defaults over upgrade (moby/datakit#605, @djs55) - go-client: improve transaction API (moby/datakit#606, @djs55)

@samoht

CHANGES: - all: update to latest version of alcotest, conduit, session, ocaml-github, ocaml-github-hooks and cohttp (moby/datakit#612, @samoht and @djs55) - github: make `User.t` abstract (moby/datakit#594, @samoht) - github: turn `Webhook.events` into a promise (moby/datakit#598, @samoht) - github: add a `Comment` module to model PR and issue comments (moby/datakit#595, @samoht) - github: change `PR.owner` to be of type `User.t` (moby/datakit#599, @samoht) - github-bridge: add the ability to sync PR's coments (moby/datakit#595, @samoht) - go-client: handle large values when reading / writing in 9db (moby/datakit#292, @simonferquel) - go-client: fix the handling of defaults over upgrade (moby/datakit#605, @djs55) - go-client: improve transaction API (moby/datakit#606, @djs55)

@samoht

CHANGES: - all: update to latest version of alcotest, conduit, session, ocaml-github, ocaml-github-hooks and cohttp (moby/datakit#612, @samoht and @djs55) - github: make `User.t` abstract (moby/datakit#594, @samoht) - github: turn `Webhook.events` into a promise (moby/datakit#598, @samoht) - github: add a `Comment` module to model PR and issue comments (moby/datakit#595, @samoht) - github: change `PR.owner` to be of type `User.t` (moby/datakit#599, @samoht) - github-bridge: add the ability to sync PR's coments (moby/datakit#595, @samoht) - go-client: handle large values when reading / writing in 9db (moby/datakit#292, @simonferquel) - go-client: fix the handling of defaults over upgrade (moby/datakit#605, @djs55) - go-client: improve transaction API (moby/datakit#606, @djs55)

djs55 changed the title ~~circle.yml: use xcode 8.3~~ attempt to fix CI Sep 28, 2017

djs55 mentioned this pull request Sep 28, 2017

Ignore trailing newlines when doing 'test and set' on reference files #611

Merged

talex5 reviewed Sep 28, 2017

View reviewed changes

samoht force-pushed the fix-ci branch 2 times, most recently from a0398e6 to 45b3cd1 Compare September 28, 2017 16:19

samoht force-pushed the fix-ci branch from 45b3cd1 to e5ef065 Compare November 6, 2017 11:54

djs55 and others added 4 commits November 10, 2017 14:27

circle.yml: attempt to fix error "Cannot find file topfind."

784eab2

This could be caused by missing environment variables during the build, hence adding another `opam config exec --` Signed-off-by: David Scott <[email protected]>

Fix make datakit

a0af16c

Signed-off-by: Thomas Gazagnaire <[email protected]>

Fix 'duplicated rule for version.o' error

169391b

Signed-off-by: Thomas Gazagnaire <[email protected]>

samoht force-pushed the fix-ci branch 4 times, most recently from 10ad65d to f541542 Compare November 16, 2017 10:54

Update to latest versions of conduit, session and ocaml-github-hooks

8031c3d

Signed-off-by: Thomas Gazagnaire <[email protected]>

samoht force-pushed the fix-ci branch from f541542 to 8031c3d Compare November 16, 2017 11:47

samoht added 2 commits November 17, 2017 15:40

ci: use ocaml 4.05 on CircleCI

a62633c

Signed-off-by: Thomas Gazagnaire <[email protected]>

ci: bump ocaml version to 4.05 in appveyor

9e578c0

Signed-off-by: Thomas Gazagnaire <[email protected]>

samoht force-pushed the fix-ci branch from 22bee65 to 9e578c0 Compare November 17, 2017 14:56

thaJeztah reviewed Nov 18, 2017

View reviewed changes

samoht self-assigned this Nov 18, 2017

Use apk add --no-cache in Dockerfile to avoid outdated cache issues

4e4f787

Thanks to @thaJeztah for the tip Signed-off-by: Thomas Gazagnaire <[email protected]>

samoht force-pushed the fix-ci branch 3 times, most recently from 5bfba93 to e579862 Compare November 20, 2017 11:01

samoht force-pushed the fix-ci branch from 4a3a9af to 686cb67 Compare November 20, 2017 12:43

samoht force-pushed the fix-ci branch from 686cb67 to 0651754 Compare November 20, 2017 12:46

samoht and others added 2 commits November 20, 2017 13:52

Simplify Dockerfiles using new features from opam2

bcd3a21

opam pin <path> now pins all the available packages in one go (yay). Signed-off-by: Thomas Gazagnaire <[email protected]>

Update self-ci

36adf9c

- datakit-ci tests are now done as part of the build - don't check that the client still works on OCaml 4.03 Requested by Thomas Gazagnaire.

samoht force-pushed the fix-ci branch from 0651754 to 36adf9c Compare November 20, 2017 12:52

samoht merged commit 8c9ff71 into moby:master Nov 21, 2017

samoht mentioned this pull request Nov 21, 2017

[WIP] Update to latest alcotest, conduit, cohttp, github-hooks and session #609

Closed

samoht mentioned this pull request Nov 21, 2017

New release of datakit ocaml/opam-repository#10802

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

attempt to fix CI #612

attempt to fix CI #612

Uh oh!

djs55 commented Sep 28, 2017 •

edited

Loading

Uh oh!

samoht commented Sep 28, 2017

Uh oh!

talex5 Sep 28, 2017

Uh oh!

samoht Sep 28, 2017

Uh oh!

samoht commented Nov 16, 2017

Uh oh!

samoht commented Nov 17, 2017

Uh oh!

samoht commented Nov 18, 2017

Uh oh!

thaJeztah Nov 18, 2017

Uh oh!

samoht commented Nov 20, 2017 •

edited

Loading

Uh oh!

talex5 commented Nov 20, 2017

Uh oh!

talex5 commented Nov 20, 2017

Uh oh!

samoht commented Nov 20, 2017

Uh oh!

samoht commented Nov 21, 2017

Uh oh!

Uh oh!

attempt to fix CI #612

attempt to fix CI #612

Uh oh!

Conversation

djs55 commented Sep 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samoht commented Sep 28, 2017

Uh oh!

talex5 Sep 28, 2017

Choose a reason for hiding this comment

Uh oh!

samoht Sep 28, 2017

Choose a reason for hiding this comment

Uh oh!

samoht commented Nov 16, 2017

Uh oh!

samoht commented Nov 17, 2017

Uh oh!

samoht commented Nov 18, 2017

Uh oh!

thaJeztah Nov 18, 2017

Choose a reason for hiding this comment

Uh oh!

samoht commented Nov 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

talex5 commented Nov 20, 2017

Uh oh!

talex5 commented Nov 20, 2017

Uh oh!

samoht commented Nov 20, 2017

Uh oh!

samoht commented Nov 21, 2017

Uh oh!

Uh oh!

djs55 commented Sep 28, 2017 •

edited

Loading

samoht commented Nov 20, 2017 •

edited

Loading