This repository was archived by the owner on Apr 20, 2024. It is now read-only.
Feature/misc fixes #122
Merged
Feature/misc fixes #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffendsommer
requested review from
BrettRToomey,
cweinberger,
martinlasek,
rasmusebbesen and
siemensikkema
Contributor
siemensikkema
left a comment
siemensikkema
left a comment
There was a problem hiding this comment.
Looks good! Some minor comments ..
| let config: AdminPanelConfig<U> = try req.make() | ||
| return U.query(on: req).all() | ||
| .flatMap(to: Response.self) { users in | ||
| let paginator: Future<OffsetPaginator<U>> = try U.query(on: req).paginate(for: req) |
Contributor
There was a problem hiding this comment.
Is it still necessary to specify the explicit type here?
Contributor
Author
There was a problem hiding this comment.
I'm afraid so since the return type is Response.
| internal func resetPasswordRequest(_ req: Request) throws -> Future<Response> { | ||
| let resetConfig: ResetConfig<U> = try req.make() | ||
| let adminPanelConfig: AdminPanelConfig<U> = try req.make() | ||
| let submission = try req.content.decode(U.RequestReset.Submission.self) |
Contributor
Author
There was a problem hiding this comment.
I'm afraid I cannot do this here. The signature looks like this:
public func decode<D>(_ content: D.Type, maxSize: Int = 65_536) throws -> Future<D> where D: Decodableand there's no overload with a default value on content.
Contributor
There was a problem hiding this comment.
ahh yeah that's a no-go then. Would be nice to detect all these occurrences in Vapor's code and fix them.
| import Flash | ||
| import Fluent | ||
| import Leaf | ||
| import Paginator |
This was referenced Nov 12, 2018
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.