Skip to content

Devoctober #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2020
Merged

Devoctober #23

merged 2 commits into from
Oct 8, 2020

Conversation

timdavison
Copy link
Contributor

  • Include querystring and fragment in urls.
  • Make 'read more' links accessible.
  • Update check on link title

This was linked to issues Oct 8, 2020
Teaser link should allow query strings and fragments #19
Closed
Update check on link title #20
Closed
Make 'Read more' links accessible #21
Closed
@timdavison timdavison requested a review from JeebsUK October 8, 2020 15:45
JeebsUK
JeebsUK approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@JeebsUK JeebsUK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approving.

@JeebsUK JeebsUK merged commit b9931ba into master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeebsUK JeebsUK JeebsUK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make 'Read more' links accessible Update check on link title Teaser link should allow query strings and fragments
2 participants
@timdavison @JeebsUK