Fix urlRefShim to pass through correct number of arguments #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Thanks for the PR! I'll write some test cases to cover this. |
ming-codes
added a commit
that referenced
this pull request
Mar 20, 2016
Fix urlRefShim to pass through correct number of arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed a problem with the url shim - if you call e.g.
selection.style("cursor")as an accessor, this gets translated by the shim intoselection.style("cursor", null)which then actually modifies the value.This particularly causes problems for the brush examples - the cursor styles disappear.
This should fix it - let me know if you need any more tests/explanation, etc.
Thanks for the project!