Skip to content

PHP 8.1 is supported #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milo merged 1 commit into from
Nov 30, 2021
Merged

PHP 8.1 is supported #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"php": ">=5.4.0"
},
"require-dev": {
"nette/tester": "~1.7.0"
"nette/tester": "^1.7 || ^2.0"
},
"suggest": {
"ext-curl": "Allows you to use Http\\CurlClient"
Expand Down
7 changes: 6 additions & 1 deletion src/Github/Paginator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ public function limit($limit)
/**
* @return void
*/
#[\ReturnTypeWillChange]
public function rewind()
{
$this->request = $this->firstRequest;
Expand All @@ -68,6 +69,7 @@ public function rewind()
/**
* @return bool
*/
#[\ReturnTypeWillChange]
public function valid()
{
return $this->request !== NULL && ($this->limit === NULL || $this->counter < $this->limit);
Expand All @@ -77,6 +79,7 @@ public function valid()
/**
* @return Http\Response
*/
#[\ReturnTypeWillChange]
public function current()
{
$this->load();
Expand All @@ -87,6 +90,7 @@ public function current()
/**
* @return int
*/
#[\ReturnTypeWillChange]
public function key()
{
return static::parsePage($this->request->getUrl());
Expand All @@ -96,11 +100,12 @@ public function key()
/**
* @return void
*/
#[\ReturnTypeWillChange]
public function next()
{
$this->load();

if ($url = static::parseLink($this->response->getHeader('Link'), 'next')) {
if ($url = static::parseLink((string) $this->response->getHeader('Link'), 'next')) {
$this->request = new Http\Request(
$this->request->getMethod(),
$url,
Expand Down