Use more recent version for libyaml #5455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcPMS
reviewed
May 12, 2025
Co-authored-by: JohnMcPMS <[email protected]>
JohnMcPMS
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a Component Governance alert for libyaml. There is no release of libyaml with this issue fixed, so the guidance was to apply the patch manually, and that's what I did when moving to vcpkg, but that doesn't play nicely with CG because it can't determine that the patch to fix the vulnerability was applied.
Instead of manually patching, this PR uses a more recent commit of libyaml (without an official release), which already has the changes we want. It uses the same commit from the last time we did a subtree update in #4583