use sass instead of node-sass
#873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CsCherrYY
requested review from
Eskibear,
jdneo and
testforstephen
as code owners
Member
|
It makes sense because .ttf is already referenced by .css file. Please double check if codicon icons are correctly rendered (e.g. pencil/edit icon in Configure Java Runtime Page) before get it merged. |
Contributor
Author
|
looks like it works as expect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #872
The current imports on ttf files will cause some errors.
The root cause might be the import statement from
sasssupports only css files, see https://sass-lang.com/documentation/at-rules/import#plain-css-imports. The ttf imports are likely redundant, and removing them brings no change to the existing pages.