navigate to welcome page after finishing feature tour #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yan Zhang <[email protected]>
jdneo
approved these changes
Feb 9, 2021
jdneo
reviewed
Feb 9, 2021
|
|
||
| private steps: JSX.Element[]; | ||
| // auto navigate to welcome page in last step | ||
| private timer: number | undefined; |
Member
There was a problem hiding this comment.
Shouldn't it declared as NodeJS.Timer?
Member
Author
There was a problem hiding this comment.
NodeJS.Timer failed webpack compilation. In Javascript, settimeout returns id of the timer, thus it's a number. In NodeJS, it's a Timer. Here this is used in a webview, so number type in plain JS should be used.
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #540 , in case users don't click the button, we navigate to welcome page after 5 seconds.