Skip to content

fix: JDK runtime setting not working with keyboard arrow #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chagong merged 1 commit into from
Sep 28, 2025
Merged

fix: JDK runtime setting not working with keyboard arrow #1503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/project-settings/assets/classpath/features/components/JdkRuntime.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ const JdkRuntime = (): JSX.Element => {
}
}

const handleDropdownChange = (event: any) => {
const selectedValue = event.target.value;
handleSelectJdk(selectedValue);
}

const onDidChangeJdk = (event: OnDidChangeJdkEvent) => {
const {data} = event;
if (data.command === "classpath.onDidChangeJdk") {
Expand Down Expand Up @@ -66,10 +71,8 @@ const JdkRuntime = (): JSX.Element => {
className="setting-section-option"
key={vmInstall.path}
value={vmInstall.path}
selected={vmInstall.path === activeVmInstallPath}
onMouseEnter={() => setOptionDescription(vmInstall.path)}
onMouseLeave={() => setOptionDescription(activeVmInstallPath)}
onClick={() => handleSelectJdk(vmInstall.path)}
>
<span>{vmInstall.name}</span>
</VSCodeOption>
Expand All @@ -84,7 +87,6 @@ const JdkRuntime = (): JSX.Element => {
id="add-new-jdk"
onMouseEnter={() => setOptionDescription("Select a JDK from the local file system.")}
onMouseLeave={() => setOptionDescription(activeVmInstallPath)}
onClick={() => handleSelectJdk("add-new-jdk")}
>
<div className="setting-section-option-action">
<span className="codicon codicon-folder-opened"/>Find a local JDK...
Expand All @@ -100,7 +102,6 @@ const JdkRuntime = (): JSX.Element => {
id="download-jdk"
onMouseEnter={() => setOptionDescription("Download a new JDK.")}
onMouseLeave={() => setOptionDescription(activeVmInstallPath)}
onClick={() => handleSelectJdk("download-jdk")}
>
<div className="setting-section-option-action">
<span className="codicon codicon-desktop-download"/>Download a new JDK...
Expand All @@ -112,7 +113,13 @@ const JdkRuntime = (): JSX.Element => {
<div className="setting-section">
<div className="flex-center mt-2">
<span className="setting-section-description mr-1">JDK:</span>
<VSCodeDropdown id="jdk-dropdown" value={activeVmInstallPath} className="setting-section-dropdown" position="below">
<VSCodeDropdown
id="jdk-dropdown"
value={activeVmInstallPath}
className="setting-section-dropdown"
position="below"
onChange={handleDropdownChange}
>
<div className="dropdown-description dropdown-above-description">
<p>{optionDescription ?? activeVmInstallPath}</p>
<VSCodeDivider></VSCodeDivider>
Expand Down