Skip to content

Conversation

@jdneo
Copy link
Member

@jdneo jdneo commented Jul 26, 2024

image

The or is not added finally, because it looks wired.

@jdneo jdneo requested a review from testforstephen as a code owner July 26, 2024 01:50
@jdneo jdneo requested a review from nickzhums July 26, 2024 01:51
"walkthrough.java.projects.inactive": "Java Project Explorer helps you to manage your projects and dependencies. Create a new project or open an existing folder to see the full features.\n[Open Command Palette](command:workbench.action.quickOpen?%22>java%22)\n__Try searching for 'Create Java Project' or 'Open Folder'__",

"walkthrough.java.codeActions": "Find available actions for your code in the editor:\n - Open the right-click menu then select \"Refactor...\" or \"Source Action...\".\n - Click on the light bulb💡.",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add OR between two options. This OR can occupy a separate line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sheng and I tested this approach and found it looked really strange. We talked with UX and think the original design actually looks better

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@jdneo jdneo merged commit 6ad36a1 into main Jul 29, 2024
@jdneo jdneo deleted the cs/walkthrough branch July 29, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants