Suggest JDK distribution by AdoptOpenJDK #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eskibear
requested changes
Mar 29, 2019
Member
Eskibear
left a comment
Eskibear
left a comment
There was a problem hiding this comment.
Workflow looks ok. But with some nits in TS files, single quotes are still used, looks it hasn't been guarded well.
jdneo
requested changes
Mar 30, 2019
jdneo
approved these changes
Mar 31, 2019
Member
Author
Single quote now only appears in webpack.config.js, which is out of the scope of ts. |
Eskibear
approved these changes
Mar 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to provide more JDK options for users to choose.
OS and architecture are automatically detected.