Skip to content

Conversation

@AenBleidd
Copy link
Contributor

@AenBleidd AenBleidd commented Oct 14, 2025

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Signed-off-by: Vitalii Koshura <[email protected]>
@AenBleidd
Copy link
Contributor Author

Looks like the failure is unrelated to this PR (but the logs are empty, so it's hard to tell for sure)

@dg0yt
Copy link
Contributor

dg0yt commented Oct 14, 2025

Oops, the feature test stopped in the middle:

Feature Test [3/6] sentry-native[core,compression]:x64-windows
Restored 1 package(s) from HTTP servers in 146 ms. Use --debug to see more details.
Removing 1/3 sentry-native:x64-windows
Elapsed time to handle sentry-native:x64-windows: 3.87 ms
Completed submission of sentry-native:[email protected] to 1 binary cache(s) in 306 ms
Installing 2/3 zlib:[email protected]...
no such file or directory
D:\a\_work\1\s\scripts\azure-pipelines\test-modified-ports.ps1 : vcpkg feature testing failed; this is usually a bug in one of the features in the port(s) edited in this pull request. Check for failure logs attached to the run in Azure Pipelines.

and not test 4...6/6.

@AenBleidd
Copy link
Contributor Author

Installing 2/3 zlib:[email protected]...
no such file or directory

Mmmm.. what??

@AenBleidd
Copy link
Contributor Author

Ok, this is definitely a CI issue, because locally it works fine.
image

@dg0yt
Copy link
Contributor

dg0yt commented Oct 15, 2025

Not only affecting this PR. I added notes to #47757.

@BillyONeal
Copy link
Member

microsoft/vcpkg-tool#1817 bug fix

@BillyONeal BillyONeal added the requires:tool-release An issue that has been fixed in the microsoft/vcpkg-tool repo and is waiting for a release thereof label Oct 16, 2025
@BillyONeal BillyONeal closed this Oct 16, 2025
@BillyONeal BillyONeal reopened this Oct 16, 2025
@BillyONeal BillyONeal removed the requires:tool-release An issue that has been fixed in the microsoft/vcpkg-tool repo and is waiting for a release thereof label Oct 16, 2025
@AenBleidd AenBleidd marked this pull request as ready for review October 17, 2025 12:01
@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry for the tool bug!

@BillyONeal BillyONeal merged commit 980c981 into microsoft:master Oct 17, 2025
19 checks passed
@AenBleidd AenBleidd deleted the vko_sentry-native_update_to_0113 branch October 18, 2025 00:28
@AenBleidd
Copy link
Contributor Author

@BillyONeal, no problem and thank you for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants