Optimize rename_or_delete to stop retrying after EXDEV

[Thomas1664]

Fixes microsoft/vcpkg#45130

Please note that there is already code in place to handle std::errc::cross_device_link for binary caching:

vcpkg-tool/src/vcpkg/binarycaching.cpp

Lines 232 to 249 in d092b51

	if (can_attempt_rename)
	{
	// if we are already on the same filesystem we can just rename into place
	m_fs.rename_or_delete(zip_path, archive_path, ec);
	}
	if (!can_attempt_rename || (ec && ec == std::make_error_condition(std::errc::cross_device_link)))
	{
	// either we need to make a copy or the rename failed because buildtrees and the binary
	// cache write target are on different filesystems, copy to a sibling in that directory and rename
	// into place
	m_fs.copy_file(zip_path, archive_temp_path, CopyOptions::overwrite_existing, ec);
	if (!ec)
	{
	m_fs.rename_or_delete(archive_temp_path, archive_path, ec);
	}
	}

However, copy-and-delete was only tried after calling fs.rename_or_delete() which tries to move the file after increasing timeouts. I decided to not move the copy-and-delete behavior to fs.rename_or_delete() because the file is first copied to a temproary location in binarycaching.cpp.

Files on different filesystems can't be renamed:

Linux: https://man7.org/linux/man-pages/man2/rename.2.html

Windows seems to support moving files but not folders across devices: https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-movefile

std::errc::cross_device_link: https://en.cppreference.com/w/cpp/error/errno_macros

Stack Overflow: https://stackoverflow.com/questions/43206198/what-does-the-exdev-cross-device-link-not-permitted-error-mean

[Thomas1664]

Before #802, files were copied to the binary cache, meaning the original file in zip_path did still exist after this function ended. However, this file is gone with rename_or_delete()

[BillyONeal]

Thanks for the improvement!

[dg0yt]

Only that ec was already lost at this point, due to L2041.

#1669