Check errno after waitpid for EINTR #1602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For me, this fixed debugging with lldb under macOS on AppleSilicon. This is also a general pattern found other code bases, including well-established code bases like the dpkg source code: - https://git.dpkg.org/cgit/dpkg/dpkg.git/tree/utils/start-stop-daemon.c?h=1.22.15#n564 - v1.22.15 is the latest version at time of commit Note that the above link actually compares the return value of waitpid against all negative values (`child < 0`). This was made to pacify static anlyzers in commit 5601b476929a896e1ab67e66e1192d5a90346e75 and is not any more correct than comparison against the documented return value of `-1` for error. - https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=5601b476929a896e1ab67e66e1192d5a90346e75
ekilmer
force-pushed
the
ek/waitpid-eintr
branch
from
25ea6d6 to
52be4e8
Compare
Member
|
Seems reasonable, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For me, this fixed debugging with lldb under macOS on AppleSilicon.
This is also a general pattern found other code bases, including well-established
code bases like the dpkg source code:
Note that the above link actually compares the return value of waitpid
against all negative values (
child < 0). This was made to pacifystatic anlyzers in commit 5601b476929a896e1ab67e66e1192d5a90346e75 and
is not any more correct than comparison against the documented return
value of
-1for error.