Skip to content

Skip looking up external files for typings #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

Conversation

sheetalkamat
Copy link
Member

No description provided.

@sheetalkamat sheetalkamat marked this pull request as ready for review June 20, 2025 19:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR centralizes the logic for resetting type acquisition state, ensures external library files are skipped when listing project files, and updates ATA tests to match the new behavior.

  • Introduce setTypeAcquisition helper to clear unresolved imports and typing files in one place
  • Replace direct assignments to p.typeAcquisition with calls to setTypeAcquisition
  • Un-comment and enable the exclusion of external library files in GetFileNames, and update ATA tests to expect “Skipped 0 typings”

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
internal/project/project.go Added setTypeAcquisition, refactored reset points to use it, and updated GetFileNames to skip external-library files
internal/project/ata_test.go Removed t.Skip calls and updated expected status strings in several ATA test cases
Comments suppressed due to low confidence (1)

internal/project/project.go:991

  • Add unit tests for GetFileNames to verify that external library files are correctly excluded when excludeFilesFromExternalLibraries is true.
		if excludeFilesFromExternalLibraries && p.program.IsSourceFileFromExternalLibrary(sourceFile) {

@sheetalkamat sheetalkamat enabled auto-merge June 20, 2025 19:33
@sheetalkamat sheetalkamat added this pull request to the merge queue Jun 20, 2025
Merged via the queue into main with commit 2aa0eb5 Jun 20, 2025
22 checks passed
@sheetalkamat sheetalkamat deleted the ataExternalImport branch June 20, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants