Skip to content

Update submodule with type ordering changes #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

jakebailey
Copy link
Member

Updates the submodule after I ported #1226 into the tsgo-port branch upstream.

@Copilot Copilot AI review requested due to automatic review settings June 19, 2025 04:48
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the TypeScript submodule baselines to reflect upstream changes in how union member orders are printed.

  • Adjusted expected output in multiple .types.diff files where unions are reordered (e.g., object | T instead of T | object).
  • Bumped the submodule commit pointer to include those ordering changes.

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
testdata/.../templateLiteralTypes3.types.diff Swapped the order of union members in output.
testdata/.../spreadObjectOrFalsy.types.diff Updated the printed order for `object
testdata/.../nonPrimitiveAndTypeVariables.types.diff Removed outdated diff block for this test.
testdata/.../nonPrimitiveAndTypeVariables.errors.txt.diff Removed outdated error baseline for this test.
testdata/.../inOperatorWithValidOperands.types.diff Swapped union member order in display.
testdata/.../inOperatorWithValidOperands.errors.txt.diff Removed outdated error baseline for this test.
testdata/.../generatorYieldContextualType.types.diff Swapped order of selection union in output.
testdata/.../conditionalTypes2.types.diff No functional changes, baseline skip markers.
testdata/.../vueLikeDataAndPropsInference2.types.diff Adjusted union order in printed function signature.
testdata/.../unionOfFunctionAndSignatureIsCallable.types.diff Harmonized union order in signatures.
testdata/.../typeGuardConstructorClassAndNumber.types.diff Swapped union order in function signature.
testdata/.../objectLiteralExcessProperties.types.diff Swapped union order in printed object type.
testdata/.../correlatedUnions.types.diff Swapped type inferences for assertedCheck.
_submodules/TypeScript Bumped TypeScript submodule commit reference.

@jakebailey jakebailey enabled auto-merge June 19, 2025 04:49
@jakebailey jakebailey requested a review from ahejlsberg June 19, 2025 15:20
@jakebailey jakebailey added this pull request to the merge queue Jun 19, 2025
@jakebailey jakebailey removed this pull request from the merge queue due to a manual request Jun 19, 2025
@jakebailey jakebailey added this pull request to the merge queue Jun 19, 2025
Merged via the queue into main with commit 60d0c08 Jun 19, 2025
22 checks passed
@jakebailey jakebailey deleted the jabaile/update-submod-ordering branch June 19, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants