Skip to content

[0.73] Fix Paper/Fabric builds not working with USE_FRAMEWORKS=static #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

shwanton
Copy link

@shwanton shwanton commented Nov 1, 2023

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary:

0.73 builds for Paper & Fabric were failing to build in xcode when USE_FRAMEWORKS=static was used in pod install

USE_FRAMEWORKS=static USE_HERMES=1 bundle exec pod install

Header search paths were changed in core. On macOS we append -macOS to our framework folders.

CleanShot 2023-10-31 at 19 36 37@2x

Changelog:

[MACOS][FIXED] - [0.73] Fix builds to use the correct header search paths

Test Plan:

USE_HERMES=1 bundle exec pod install
@shwanton shwanton changed the title [0.73] Fix local build not finding deps w/ cocoapods [0.73] Fix Paper/Fabric builds not working with USE_FRAMEWORKS=static Nov 1, 2023
@shwanton
Copy link
Author

shwanton commented Nov 1, 2023

After further testing. Fabric & Paper builds w/o USE_FRAMEWORKS=static are working fine in 0.73.
Repurposing this diff to fix use_frameworks for macOS.

@shwanton
Copy link
Author

shwanton commented Nov 3, 2023

Closing in favor of #1967

@shwanton shwanton closed this Nov 3, 2023
@shwanton shwanton deleted the 0.73-fix-cocoapods-headers branch November 3, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant