chore: change recommended snapshot extension to .aria.yml #34963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
PR Overview
This PR updates the recommended snapshot extension from ".snapshot.yml" to ".aria.yml" to standardize file naming across tests, source code, and documentation.
- Updated test assertions and snapshot file paths in test files
- Modified helper functions and SnapshotRecorder configuration for the new extension
- Adjusted documentation to reflect the new snapshot naming convention
Reviewed Changes
| File | Description |
|---|---|
| tests/playwright-test/playwright.artifacts.spec.ts | Updated expected file names for snapshot artifacts |
| tests/playwright-test/aria-snapshot-file.spec.ts | Changed snapshot file names and references to .aria.yml |
| packages/playwright/src/matchers/toMatchAriaSnapshot.ts | Adjusted expected file extension for snapshot comparisons |
| packages/playwright/src/index.ts | Updated SnapshotRecorder to use the .aria.yml extension |
| docs/src/api/class-locatorassertions.md | Revised documentation to use .aria.yml in snapshot examples |
| docs/src/aria-snapshots.md | Updated instructions for storing snapshots with the new extension |
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Contributor
Test results for "tests 1"1 failed 5 flaky38628 passed, 796 skipped Merge workflow run. |
dgozman
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.