chore: move zones into platform #34786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test results for "tests 1"1 fatal errors, not part of any test 9 flaky38545 passed, 793 skipped Merge workflow run. |
yury-s
approved these changes
Feb 13, 2025
| } | ||
|
|
||
| pop() { | ||
| return new NodeZone(this._zone.without('apiZone')); |
Member
There was a problem hiding this comment.
pop is very confusing name for this operation, usually pop() returns the element that was removed, not the remainder.
Member
Author
There was a problem hiding this comment.
I can do enter/exit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.