-
Notifications
You must be signed in to change notification settings - Fork 4.9k
fix: allow relative userDataDir #34710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
yury-s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we need to resolve it in the other two browsers?
f8727cf to
fa764dd
Compare
fa764dd to
f944809
Compare
Only Chromium on Windows behaved weirdly - moved it a layer up to normalise it everywhere! |
This comment has been minimized.
This comment has been minimized.
| * limitations under the License. | ||
| */ | ||
|
|
||
| import path from 'path'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the happy linting days!
a384d20 to
0b658e4
Compare
This comment has been minimized.
This comment has been minimized.
0b658e4 to
5764a76
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Max Schmitt <[email protected]>
Test results for "tests 1"15 flaky37841 passed, 654 skipped Merge workflow run. |
A relative directory in Chromium's user-data-dir argument ends up getting resolved against the directory of
chrome.exerather than theCWDon Windows.Relates https://chromium-review.googlesource.com/c/chromium/src/+/2717314
Fixes #34700