Skip to content

Conversation

@mxschmitt
Copy link
Contributor

@mxschmitt mxschmitt commented Feb 10, 2025

A relative directory in Chromium's user-data-dir argument ends up getting resolved against the directory of chrome.exe rather than the CWD on Windows.

Relates https://chromium-review.googlesource.com/c/chromium/src/+/2717314

Fixes #34700

@github-actions

This comment has been minimized.

Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we need to resolve it in the other two browsers?

@mxschmitt mxschmitt force-pushed the relative/user-data-dir branch from f8727cf to fa764dd Compare February 11, 2025 11:53
@mxschmitt mxschmitt force-pushed the relative/user-data-dir branch from fa764dd to f944809 Compare February 11, 2025 11:53
@mxschmitt
Copy link
Contributor Author

Why don't we need to resolve it in the other two browsers?

Only Chromium on Windows behaved weirdly - moved it a layer up to normalise it everywhere!

@github-actions

This comment has been minimized.

* limitations under the License.
*/

import path from 'path';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the happy linting days!

@mxschmitt mxschmitt force-pushed the relative/user-data-dir branch from a384d20 to 0b658e4 Compare February 11, 2025 13:40
@github-actions

This comment has been minimized.

@mxschmitt mxschmitt force-pushed the relative/user-data-dir branch from 0b658e4 to 5764a76 Compare February 11, 2025 13:42
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Test results for "tests 1"

15 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:72:3 › should remove cookies by name regex @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-har.spec.ts:455:3 › should update har.zip for page @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsertype-connect.spec.ts:576:5 › launchServer › should properly disconnect when connection closes from the client side @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:224:1 › should complain about newer version of trace in old viewer @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1133:1 › should display language-specific locators @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1336:1 › should highlight locator in iframe while typing @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1551:1 › should not leak recorders @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-event-popup.spec.ts:28:3 › should work with window features @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37841 passed, 654 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: user_data_dir in launch_persistent_context() resolves relative paths relative to browser executable instead of current working directory

3 participants