fix(har timing): record connect timing for proxied connections
#32855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
changed the title
Skn0tt
changed the title
connect timing for proxied connections
This comment has been minimized.
This comment has been minimized.
mxschmitt
reviewed
Sep 27, 2024
Co-authored-by: Max Schmitt <[email protected]> Signed-off-by: Simon Knott <[email protected]>
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"1 flaky36416 passed, 757 skipped Merge workflow run. |
Contributor
|
Do we have to upgrade the deps? I am always wary of introducing regressions. |
Member
Author
|
For SOCKS proxy we don't, but for HTTP proxy yes. The If we don't want to update, another alternative would be leave things as is for the HTTP proxy and set |
Member
Author
|
Could you give this another look @dgozman? |
dgozman
approved these changes
Oct 7, 2024
Skn0tt
added a commit
that referenced
this pull request
Oct 8, 2024
…ns" (#32855) (#33003) This reapplies what we reverted in #32989. Max and me debugged this, and found that the test failures come from SOCKS proxy now preferring IPv6 over IPv4. We've updated the tests and made sure that this doesn't mask any breaking change. I'm enabling CQ1 to make sure we don't oversee any other CI failures.
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Jan 29, 2025
…onnections" (microsoft#32855) (microsoft#33003)" This reverts commit 042161e.
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Jan 29, 2025
…d connect timing for proxied connections" (microsoft#32855) (microsoft#33003)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug discovered in #32647. When using http proxy, the
connectevent isn't emitted so we don't populatetcpConnectionAt. The updated version ofhttps-proxy-agentemits aproxyConnectas a replacement, so this PR updates and listens to that event.For socks proxies, the
on("socket")event is emitted once the SOCKS connection is established, which is the equivalent of having a TCP connection available.