chore(chromium): nicer error when running as root without --no-sandbox (#2214)

yury-s · web-flow · commit f10e8c4d4725 · 2020-05-12T16:43:15.000-07:00
diff --git a/src/server/chromium.ts b/src/server/chromium.ts
@@ -95,6 +95,9 @@ export class Chromium extends AbstractBrowserType<CRBrowser> {
       temporaryUserDataDir = userDataDir;
     }
 
+    const runningAsRoot = process.geteuid && process.geteuid() === 0;
+    assert(!runningAsRoot || args.includes('--no-sandbox'), 'Cannot launch Chromium as root without --no-sandbox. See https://crbug.com/638180.');
+
     const chromeArguments = [];
     if (!ignoreDefaultArgs)
       chromeArguments.push(...this._defaultArgs(options, launchType, userDataDir));

Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,9 @@ export class Chromium extends AbstractBrowserType<CRBrowser> {`
`95`	`95`	`temporaryUserDataDir = userDataDir;`
`96`	`96`	`}`
`97`	`97`
	`98`	`+ const runningAsRoot = process.geteuid && process.geteuid() === 0;`
	`99`	`+ assert(!runningAsRoot \|\| args.includes('--no-sandbox'), 'Cannot launch Chromium as root without --no-sandbox. See https://crbug.com/638180.');`
	`100`	`+`
`98`	`101`	`const chromeArguments = [];`
`99`	`102`	`if (!ignoreDefaultArgs)`
`100`	`103`	`chromeArguments.push(...this._defaultArgs(options, launchType, userDataDir));`