NetworkPkg: Add IP address error handling in PxeBcDhcp6Sarr() #1596
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return `EFI_DEVICE_ERROR` if the IA state is invalid instead of asserting to have consistent error handling regardless of assertion enable status and to allow better error recovery in PXE boot scenarios. Signed-off-by: Michael Kubacki <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202502 #1596 +/- ##
================================================
Coverage ? 0.55%
================================================
Files ? 165
Lines ? 71950
Branches ? 1751
================================================
Hits ? 402
Misses ? 71541
Partials ? 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cfernald
approved these changes
Dec 12, 2025
apop5
approved these changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return
EFI_DEVICE_ERRORif the IA state is invalid instead of asserting to have consistent error handling regardless of assertion enable status and to allow better error recovery in PXE boot scenarios.How This Was Tested
Integration Instructions