Skip to content

Fix up "Use symbolic GitHub Actions Node.js versions (#49403)" #49420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Fix up "Use symbolic GitHub Actions Node.js versions (#49403)" #49420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c9521f
Fix up "Use symbolic GitHub Actions Node.js versions (#49403)"
jablko Jun 7, 2022
1974080
Use npm v6 to update package-lock.json
jablko Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/nightly.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
# Use NODE_AUTH_TOKEN environment variable to authenticate to this registry.
registry-url: https://registry.npmjs.org/
- name: Setup and publish nightly
run: |
npm whoami
Expand All @@ -26,4 +29,4 @@ jobs:
gulp clean
npm publish --tag next
env:
NPM_TOKEN: ${{secrets.npm_token}}
NODE_AUTH_TOKEN: ${{secrets.npm_token}}
4 changes: 3 additions & 1 deletion .github/workflows/update-package-lock.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,14 @@ jobs:
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v3
with:
node-version: 14

- name: Configure git and update package-lock.json
run: |
git config user.email "[email protected]"
git config user.name "TypeScript Bot"
npm install --package-lock-only
npm install --package-lock-only --ignore-scripts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this is run with node 14, I think this can be dropped, though if it exists it probably won't be harmful. Shame about that npm bug.

Copy link
Member

@jakebailey jakebailey Jun 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this probably wouldn't work in npm7+ at all, because npm install doesn't just overwrite package-lock with new versions anymore. When we switch to lockfile v2, I think we'll have to come up with a new updating system.

git add -f package-lock.json
if git commit -m "Update package-lock.json"; then
git push
Expand Down