Disallow let\const declarations in the same scope with var declarations. #2027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at var is not shadowed by the let\const from the inner scope
| // Do not consider let and const declarations, as duplicate block-scoped declarations | ||
| // are handled by the binder. | ||
| // We are only looking for var declarations that step on const declarations from a | ||
| // are handled by the binder. |
There was a problem hiding this comment.
Trim this trailing whitespace.
|
👍 |
| // let x; | ||
| // var x; | ||
| // } | ||
| // 'var x' will be placed into the function locals and 'let x' - into the locals of the block |
There was a problem hiding this comment.
So you are saying that you want vars and lets to go to one place, because you want them to collide. The choice of function locals as opposed to block locals is arbitrary, it just has to be the same for both declaration kinds. Correct?
There was a problem hiding this comment.
Yeah, i'd add a comment to that effect. I think using hte function as the location makes sense though, as that's where we put parameters. (we should also add tests for parameters/locals/lets (if they collide or not))
|
👍 |
vladima
added a commit
that referenced
this pull request
Feb 13, 2015
Disallow let\const declarations in the same scope with var declarations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent nested let\const to shadow hoisted variables Fixes #1910.