-
Notifications
You must be signed in to change notification settings - Fork 854
feat: Add top_p and seed params to OpenAIDefaults #2410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add top_p and seed params to OpenAIDefaults #2410
Conversation
Introduces support for setting, getting, and resetting 'seed' and 'top_p' parameters in OpenAIDefaults for both Python and Scala. Adds input validation for 'temperature' (0.0-2.0) and 'top_p' (0.0-1.0) in both languages. Updates tests to cover new parameters and validation logic.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2410 +/- ##
==========================================
- Coverage 84.48% 84.45% -0.04%
==========================================
Files 332 332
Lines 17251 17271 +20
Branches 1552 1555 +3
==========================================
+ Hits 14575 14586 +11
- Misses 2676 2685 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mhamilton723
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, minor Qs
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Related Issues/PRs
Close #2407
Close #2408
What changes are proposed in this pull request?
Add pass through new parameters that can be configured for openai chat.compleitions calls
How is this patch tested?
Added tests to check for updates
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?
Added exmaples in Jupyter Notebook here
website/docs/documentationfolder.Make sure you choose the correct class
estimators/transformersand namespace.DocTablepoints to correct API link.yarn run startto make sure the website renders correctly.<!--pytest-codeblocks:cont-->before each python code blocks to enable auto-tests for python samples.WebsiteSamplesTestsjob pass in the pipeline.