Skip to content

Conversation

@sss04
Copy link
Contributor

@sss04 sss04 commented Apr 7, 2025

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

User found a bug where URLs set without a trailing "/" don't work. Checking for the "/" and adding it now.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

@sss04 sss04 requested a review from mhamilton723 as a code owner April 7, 2025 17:55
@sss04
Copy link
Contributor Author

sss04 commented Apr 7, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.82%. Comparing base (26baa09) to head (85db5ff).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2364      +/-   ##
==========================================
- Coverage   84.67%   82.82%   -1.86%     
==========================================
  Files         331      331              
  Lines       17179    17180       +1     
  Branches     1550     1544       -6     
==========================================
- Hits        14547    14229     -318     
- Misses       2632     2951     +319     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sss04 sss04 changed the title [fix] Adding trailing / to URLs set fix: Adding trailing / to URLs set Apr 7, 2025
mhamilton723
mhamilton723 previously approved these changes Apr 8, 2025
@sss04 sss04 enabled auto-merge (squash) April 8, 2025 19:39
@sss04
Copy link
Contributor Author

sss04 commented Apr 10, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723
Copy link
Contributor

/azp run

@mhamilton723 mhamilton723 disabled auto-merge April 11, 2025 16:07
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit e12b0a1 into microsoft:master Apr 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants