Skip to content

Conversation

@sss04
Copy link
Contributor

@sss04 sss04 commented Mar 27, 2025

We noticed that Spark jobs didn't have trident.artifact.workspace.id set, rather opting for trident.workspace.id. So, we've added an check to get trident.workspace.id if trident.artifact.workspace.id is not set.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

@sss04 sss04 requested a review from mhamilton723 as a code owner March 27, 2025 18:17
@sss04
Copy link
Contributor Author

sss04 commented Mar 27, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sss04 sss04 changed the title [fix] Workspace ID fix for Spark Jobs fix: Workspace ID fix for Spark Jobs Mar 27, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.15%. Comparing base (7878fec) to head (6807673).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...crosoft/azure/synapse/ml/fabric/FabricClient.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2358      +/-   ##
==========================================
- Coverage   83.67%   81.15%   -2.53%     
==========================================
  Files         331      331              
  Lines       17177    17177              
  Branches     1526     1539      +13     
==========================================
- Hits        14373    13940     -433     
- Misses       2804     3237     +433     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mhamilton723 mhamilton723 merged commit 6c9c9ce into microsoft:master Mar 27, 2025
6 checks passed
@sss04 sss04 deleted the shyamsai/workspaceIDfix branch March 28, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants