Build fails with gcc 12

[lgbaldoni]

Using procmon 1.0.1 on openSUSE Tumbleweed, with the following cmake parameters:

/usr/bin/cmake /home/abuild/rpmbuild/BUILD/ProcMon-for-Linux-1.0.1/. '-GUnix Makefiles' -DCMAKE_INSTALL_PREFIX:PATH=/usr -DINCLUDE_INSTALL_DIR:PATH=/usr/include -DLIB_INSTALL_DIR:PATH=/usr/lib64 -DSYSCONF_INSTALL_DIR:PATH=/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/share -DCMAKE_INSTALL_LIBDIR:PATH=lib64 -DCMAKE_INSTALL_LIBEXECDIR=/usr/libexec -DCMAKE_BUILD_TYPE=RelWithDebInfo '-DCMAKE_C_FLAGS=-O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -DNDEBUG' '-DCMAKE_CXX_FLAGS=-O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -DNDEBUG' '-DCMAKE_Fortran_FLAGS=-O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -DNDEBUG' '-DCMAKE_EXE_LINKER_FLAGS=-flto=auto -Wl,--as-needed -Wl,--no-undefined -Wl,-z,now' '-DCMAKE_MODULE_LINKER_FLAGS=-flto=auto -Wl,--as-needed' '-DCMAKE_SHARED_LINKER_FLAGS=-flto=auto -Wl,--as-needed -Wl,--no-undefined -Wl,-z,now' -DLIB_SUFFIX=64 -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON -DBUILD_SHARED_LIBS:BOOL=ON -DBUILD_STATIC_LIBS:BOOL=OFF -DCMAKE_COLOR_MAKEFILE:BOOL=OFF -DCMAKE_INSTALL_DO_STRIP:BOOL=OFF -DCMAKE_MODULES_INSTALL_DIR=/usr/lib64/cmake/procmon

and this is where it fails:

[ 53%] Building CXX object src/tracer/CMakeFiles/tracer-static.dir/ebpf/raw_ebpf_event.cpp.o
cd /home/abuild/rpmbuild/BUILD/ProcMon-for-Linux-1.0.1/build/src/tracer && /usr/bin/c++  -I/home/abuild/rpmbuild/BUILD/ProcMon-for-Linux-1.0.1/build/src -I/usr/include/bcc/compat -I/usr/include/ncurses -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -DNDEBUG -g -fno-omit-frame-pointer -DELPP_THREAD_SAFE -D ELPP_DEFAULT_LOG_FILE='"/var/log/procmon.log"' -O2 -g -DNDEBUG -std=gnu++17 -MD -MT src/tracer/CMakeFiles/tracer-static.dir/ebpf/raw_ebpf_event.cpp.o -MF CMakeFiles/tracer-static.dir/ebpf/raw_ebpf_event.cpp.o.d -o CMakeFiles/tracer-static.dir/ebpf/raw_ebpf_event.cpp.o -c /home/abuild/rpmbuild/BUILD/ProcMon-for-Linux-1.0.1/src/tracer/ebpf/raw_ebpf_event.cpp
[ 57%] Building CXX object src/tracer/CMakeFiles/tracer-static.dir/ebpf/syscall_schema.cpp.o
cd /home/abuild/rpmbuild/BUILD/ProcMon-for-Linux-1.0.1/build/src/tracer && /usr/bin/c++  -I/home/abuild/rpmbuild/BUILD/ProcMon-for-Linux-1.0.1/build/src -I/usr/include/bcc/compat -I/usr/include/ncurses -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -g -DNDEBUG -g -fno-omit-frame-pointer -DELPP_THREAD_SAFE -D ELPP_DEFAULT_LOG_FILE='"/var/log/procmon.log"' -O2 -g -DNDEBUG -std=gnu++17 -MD -MT src/tracer/CMakeFiles/tracer-static.dir/ebpf/syscall_schema.cpp.o -MF CMakeFiles/tracer-static.dir/ebpf/syscall_schema.cpp.o.d -o CMakeFiles/tracer-static.dir/ebpf/syscall_schema.cpp.o -c /home/abuild/rpmbuild/BUILD/ProcMon-for-Linux-1.0.1/src/tracer/ebpf/syscall_schema.cpp
In file included from /home/abuild/rpmbuild/BUILD/ProcMon-for-Linux-1.0.1/src/tracer/ebpf/syscall_schema.cpp:4:
/home/abuild/rpmbuild/BUILD/ProcMon-for-Linux-1.0.1/src/tracer/ebpf/syscall_schema.h: In static member function 'static std::vector<SyscallSchema::SyscallSchema> SyscallSchema::Utils::CollectSyscallSchema()':
/home/abuild/rpmbuild/BUILD/ProcMon-for-Linux-1.0.1/src/tracer/ebpf/syscall_schema.h:100:26: error: 'strcpy' is not a member of 'std'
  100 |                     std::strcpy(schema.syscallName, match[2].str().c_str());
      |                          ^~~~~~
/home/abuild/rpmbuild/BUILD/ProcMon-for-Linux-1.0.1/src/tracer/ebpf/syscall_schema.h:124:34: error: 'strcpy' is not a member of 'std'
  124 |                             std::strcpy(schema.argNames[argCount], argName.c_str());
      |                                  ^~~~~~
make[2]: *** [src/tracer/CMakeFiles/tracer-static.dir/build.make:121: src/tracer/CMakeFiles/tracer-static.dir/ebpf/syscall_schema.cpp.o] Error 1

No error with gcc 11.

[realyukii]

same issue also happened on arch linux:

[hemlo@zero build]$  make
[  2%] Compressing Procmon man page
[  2%] Built target procmonManPageCompress
[  4%] Compressing changelog
[  4%] Built target procmonChangelogCompress
[  6%] Building C object CMakeFiles/sqlite3-static.dir/vendor/sqlite3/sqlite3.c.o
[  8%] Linking C static library libsqlite3-static.a
[  8%] Built target sqlite3-static
[ 10%] Building CXX object CMakeFiles/getsyscalls.dir/getsyscalls/getsyscalls.cpp.o
[ 12%] Linking CXX executable getsyscalls
[ 12%] Built target getsyscalls
[ 14%] Running getsyscalls
Fetching syscall table from https://raw.githubusercontent.com/torvalds/linux/v6.7/arch/x86/entry/syscalls/syscall_64.tbl ...
Running getsyscalls on syscall_6.7.tbl and storing output in ../src/tracer/ebpf/syscalls.h ...
Syscalls have been parsed and written to ../src/tracer/ebpf/syscalls.h
[ 14%] Built target run_getsyscalls
[ 16%] Building EBPF object procmonEBPFkern5.6-_core.o
[ 18%] Packing procmonEBPFkern5.6-_core.o into procmonEBPFkern5.6-_core.o.o
[ 20%] Building EBPF object procmonEBPFkern4.17-5.1.o
[ 22%] Packing procmonEBPFkern4.17-5.1.o into procmonEBPFkern4.17-5.1.o.o
[ 24%] Building EBPF object procmonEBPFkern4.17-5.1_core.o
[ 26%] Packing procmonEBPFkern4.17-5.1_core.o into procmonEBPFkern4.17-5.1_core.o.o
[ 28%] Building EBPF object procmonEBPFkern5.2.o
[ 30%] Packing procmonEBPFkern5.2.o into procmonEBPFkern5.2.o.o
[ 32%] Building EBPF object procmonEBPFkern5.2_core.o
[ 34%] Packing procmonEBPFkern5.2_core.o into procmonEBPFkern5.2_core.o.o
[ 36%] Building EBPF object procmonEBPFkern5.3-5.5.o
[ 38%] Packing procmonEBPFkern5.3-5.5.o into procmonEBPFkern5.3-5.5.o.o
[ 40%] Building EBPF object procmonEBPFkern5.3-5.5_core.o
[ 42%] Packing procmonEBPFkern5.3-5.5_core.o into procmonEBPFkern5.3-5.5_core.o.o
[ 44%] Building EBPF object procmonEBPFkern5.6-.o
[ 46%] Packing procmonEBPFkern5.6-.o into procmonEBPFkern5.6-.o.o
[ 48%] Building CXX object CMakeFiles/procmon.dir/src/procmon.cpp.o
In file included from /home/reyuki/software/open-source/ProcMon-for-Linux/src/configuration/../tracer/ebpf/ebpf_tracer_engine.h:25,
                 from /home/reyuki/software/open-source/ProcMon-for-Linux/src/configuration/procmon_configuration.h:34,
                 from /home/reyuki/software/open-source/ProcMon-for-Linux/src/procmon.cpp:21:
/home/reyuki/software/open-source/ProcMon-for-Linux/src/configuration/../tracer/ebpf/syscall_schema.h: In static member function ‘static std::vector<SyscallSchema> Utils::CollectSyscallSchema()’:
/home/reyuki/software/open-source/ProcMon-for-Linux/src/configuration/../tracer/ebpf/syscall_schema.h:85:26: error: ‘strcpy’ is not a member of ‘std’; did you mean ‘strcpy’?
   85 |                     std::strcpy(schema.syscallName, syscall.name.c_str());
      |                          ^~~~~~
In file included from /home/reyuki/software/open-source/ProcMon-for-Linux/src/configuration/../storage/../common/telemetry.h:21,
                 from /home/reyuki/software/open-source/ProcMon-for-Linux/src/configuration/../storage/storage_engine.h:24,
                 from /home/reyuki/software/open-source/ProcMon-for-Linux/src/configuration/../storage/mock_storage_engine.h:25,
                 from /home/reyuki/software/open-source/ProcMon-for-Linux/src/configuration/procmon_configuration.h:29:
/usr/include/string.h:141:14: note: ‘strcpy’ declared here
  141 | extern char *strcpy (char *__restrict __dest, const char *__restrict __src)
      |              ^~~~~~
/home/reyuki/software/open-source/ProcMon-for-Linux/src/configuration/../tracer/ebpf/syscall_schema.h:109:34: error: ‘strcpy’ is not a member of ‘std’; did you mean ‘strcpy’?
  109 |                             std::strcpy(schema.argNames[argCount], argName.c_str());
      |                                  ^~~~~~
/usr/include/string.h:141:14: note: ‘strcpy’ declared here
  141 | extern char *strcpy (char *__restrict __dest, const char *__restrict __src)
      |              ^~~~~~
make[2]: *** [CMakeFiles/procmon.dir/build.make:159: CMakeFiles/procmon.dir/src/procmon.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:257: CMakeFiles/procmon.dir/all] Error 2
make: *** [Makefile:91: all] Error 2
[hemlo@zero build]$  gcc --version
gcc (GCC) 14.2.1 20240910
Copyright (C) 2024 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

related issue: #115