Skip to content

Conversation

@vanzue
Copy link
Contributor

@vanzue vanzue commented Aug 8, 2025

Summary of the Pull Request

Fix a crash in settings page due to not found converter

AI Summary

This pull request makes a small update to the MouseUtilsPage.xaml file to use the correct resource for converting boolean values to visibility states in the UI.

  • Updated the Visibility binding on an InfoBar to use the ReverseBoolToVisibilityConverter instead of the incorrect BoolToReverseVisibilityConverter resource.

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Regression caused by #40214

Validation Steps Performed

image

@yeelam-gordon yeelam-gordon requested a review from Copilot August 8, 2025 05:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a crash in the settings page that was caused by an incorrect converter reference. The issue was that the code was using a non-existent converter name BoolToReverseVisibilityConverter instead of the correct ReverseBoolToVisibilityConverter.

  • Corrected a converter reference from BoolToReverseVisibilityConverter to ReverseBoolToVisibilityConverter

@yeelam-gordon yeelam-gordon added the Product-Settings The standalone PowerToys Settings application label Aug 8, 2025
@yeelam-gordon yeelam-gordon added this to the PowerToys 0.93 milestone Aug 8, 2025
@vanzue vanzue merged commit 062234c into main Aug 8, 2025
18 checks passed
@vanzue vanzue deleted the dev/vanzue/mouse-util-crash branch November 5, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Product-Settings The standalone PowerToys Settings application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants