-
-
Notifications
You must be signed in to change notification settings - Fork 2k
OcWeb: Improve OC corresponding JS method #2879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
play-services-core/src/main/kotlin/org/microg/gms/accountsettings/ui/MainActivity.kt
Outdated
Show resolved
Hide resolved
...-services-core/src/main/kotlin/org/microg/gms/accountsettings/ui/bridge/OcAndroidIdBridge.kt
Outdated
Show resolved
Hide resolved
...-services-core/src/main/kotlin/org/microg/gms/accountsettings/ui/bridge/OcAndroidIdBridge.kt
Outdated
Show resolved
Hide resolved
play-services-core/src/main/kotlin/org/microg/gms/accountsettings/ui/bridge/OcAppBarBridge.kt
Outdated
Show resolved
Hide resolved
...services-core/src/main/kotlin/org/microg/gms/accountsettings/ui/bridge/OcClientInfoBridge.kt
Outdated
Show resolved
Hide resolved
...services-core/src/main/kotlin/org/microg/gms/accountsettings/ui/bridge/OcFilePickerBridge.kt
Outdated
Show resolved
Hide resolved
...services-core/src/main/kotlin/org/microg/gms/accountsettings/ui/bridge/OcClientInfoBridge.kt
Outdated
Show resolved
Hide resolved
play-services-core/src/main/kotlin/org/microg/gms/accountsettings/ui/MainActivity.kt
Outdated
Show resolved
Hide resolved
play-services-core/src/main/java/org/microg/gms/settings/GmsFileProvider.kt
Outdated
Show resolved
Hide resolved
I tried uploading a user avatar with this merged and it did not work for me. The button is not responsive and there is no log message. |
I suspect this is a problem with the webview. I tried to implement a method to get local images from the loaded js. I couldn't select the file through the device webview, but it was normal through chrome or computer chrome. document.getElementById("uploadBtn").addEventListener("click", () => {
}); |
I'm a little surprised because there is specific code for user avatar uploading in this PR, but I can't find how to trigger it. The only bridge functions that I see being called are:
Notably, there is no call to any |
@mar-v-in There are two places to change your avatar. The first replacement can execute ocFilePicker normally, but the second one cannot execute normally. |
3846947
to
87d233e
Compare
Supplement the JS method corresponding to OcIdWebview.
Also modify the following: