[Suggestion]: Add support for DataMaps

[no-name-provided]

Suggestion

Please add support for searching and displaying ingredients based on their datamap values. Datamaps are a NeoForge feature that generalizes tags, and, like tags, can provide useful information to players. For items, the NeoForge tooltip events can be used to manually add this information. For tags, this information is automatically appended (and searchable). However, there appears to be no side-effect free way to manipulate tooltips on fluid stacks. This is a problem that only arises when a mod displays fluidstacks in a GUI, so I don't anticipate a solution from NeoForge.

Personal motivation: For one of my mods, I would like to display additional information in all contexts, including the search grid, and make this information searchable. Currently, there appears to be no way to add a tooltip (or tooltip callback) to a fluidstack that renders in all contexts. Tags are automatically supported. It would be nice if I could provide a callback that let JEI parse my Datamap, and render sensible, searchable, tooltip lines.

[mezz]

Thanks for the suggestion!
I would like to push back on this request, because I think the best solution here is really to add a fluid tooltip method in NeoForge.
There are plenty of mods that show fluids in GUIs, and it would be valuable for them to have some unified solution.
Then, I could use it here instead of having my own custom logic:

JustEnoughItems/NeoForge/src/main/java/mezz/jei/neoforge/platform/FluidHelper.java

Lines 71 to 90 in 6b615d1

	@Override
	public void getTooltip(List<Component> tooltip, FluidStack ingredient, TooltipFlag tooltipFlag) {
	Fluid fluid = ingredient.getFluid();
	if (fluid.isSame(Fluids.EMPTY)) {
	return;
	}
	Component displayName = getDisplayName(ingredient);
	tooltip.add(displayName);
	if (tooltipFlag.isAdvanced()) {
	Registry<Fluid> fluidRegistry = RegistryUtil.getRegistry(Registries.FLUID);
	Identifier resourceLocation = fluidRegistry.getKey(fluid);
	if (resourceLocation != null && resourceLocation != BuiltInRegistries.FLUID.getDefaultKey()) {
	MutableComponent advancedId = Component.literal(resourceLocation.toString())
	.withStyle(ChatFormatting.DARK_GRAY);
	tooltip.add(advancedId);
	}
	}
	}

[no-name-provided]

Coincidentally, that's the method I ended up injecting into. It's more-or-less where I imagined the callback would go.

It would be nice if there were a unified way to display fluidstack tooltips, so it may make sense for you to open an issue on the NeoForge GitHub and table this until you hear back. However, my expectation is that this will be a low priority, or explicitly rejected.

---

On a tangential topic: is it intentional that search strings with spaces never match tooltips (eg, "Attack Damage" matches nothing)?

[mezz]

Yeah this is an intentional implementation detail for how tooltip strings are searched:

JustEnoughItems/Gui/src/main/java/mezz/jei/gui/ingredients/ListElementInfo.java

Lines 145 to 148 in 71ec02e

	// Split tooltip strings into words to keep them from being too long.
	// Longer strings are more expensive for the suffix tree to handle.
	String[] strings = string.split(" ");
	Collections.addAll(result, strings);

[mezz]

I created a NeoForge PR here:

• [1.21.x] Add tooltip support for FluidStack neoforged/NeoForge#2887