Skip to content

Conversation

@metrue
Copy link
Owner

@metrue metrue commented Dec 31, 2019

Issue:
Summary:

The checklist before PR is ready for review:

  • has unit testing for new added codes
  • has functional testing for new added features
  • has checked the lint or style issues
  • README updated if need

* add node-fetch to fx-node-base image, then we can use 'fetch' in
JavaScript/Node function

* bump version
* enable autoremove to be configurable

* bump version
@codecov
Copy link

codecov bot commented Dec 31, 2019

Codecov Report

Merging #441 into production will increase coverage by 0.08%.
The diff coverage is 80%.

Impacted file tree graph

@@              Coverage Diff               @@
##           production     #441      +/-   ##
==============================================
+ Coverage       33.84%   33.93%   +0.08%     
==============================================
  Files              49       50       +1     
  Lines            2210     2213       +3     
==============================================
+ Hits              748      751       +3     
  Misses           1339     1339              
  Partials          123      123
Impacted Files Coverage Δ
container_runtimes/docker/http/api.go 0% <0%> (ø) ⬆️
container_runtimes/docker/sdk/docker.go 45.58% <100%> (ø) ⬆️
config/env.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33cb4ce...3d7f7b0. Read the comment docs.

@metrue metrue merged commit 4e8a628 into production Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants