ensure passed mesh is initialized #85
Merged
+15
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amirafzali has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88797233. |
meta-cla
bot
added
the
CLA Signed
amirafzali
added a commit
to amirafzali/torchstore
that referenced
this pull request
Dec 10, 2025
Summary: Pull Request resolved: meta-pytorch#85 I think this a bug, if the passed mesh has not initialized yet then subsequent calls fail. Differential Revision: D88797233
amirafzali
force-pushed
the
export-D88797233
branch
from
7a095fc to
105c76d
Compare
amirafzali
added a commit
to amirafzali/torchstore
that referenced
this pull request
Dec 10, 2025
Summary: Pull Request resolved: meta-pytorch#85 I think this a bug, if the passed mesh has not initialized yet then subsequent calls fail. Differential Revision: D88797233
amirafzali
force-pushed
the
export-D88797233
branch
from
105c76d to
f5790f7
Compare
amirafzali
added a commit
to amirafzali/torchstore
that referenced
this pull request
Dec 11, 2025
Summary: Pull Request resolved: meta-pytorch#85 I think this a bug, if the passed mesh has not initialized yet then subsequent calls fail. Differential Revision: D88797233
amirafzali
force-pushed
the
export-D88797233
branch
from
f5790f7 to
8daf07d
Compare
amirafzali
added a commit
to amirafzali/torchstore
that referenced
this pull request
Dec 11, 2025
Summary: Pull Request resolved: meta-pytorch#85 I think this a bug, if the passed mesh has not initialized yet then subsequent calls fail. Differential Revision: D88797233
amirafzali
force-pushed
the
export-D88797233
branch
from
8daf07d to
91bf71b
Compare
Summary: Using socket.hostname as default volume_id for initialization. Similar approach is used in LocalRankStrategy Reviewed By: LucasLLC Differential Revision: D88797234
Summary: I think this a bug, if the passed mesh has not initialized yet then subsequent calls fail. Reviewed By: LucasLLC Differential Revision: D88797233
amirafzali
force-pushed
the
export-D88797233
branch
from
91bf71b to
88ec3c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: I think this a bug, if the passed mesh has not initialized yet then subsequent calls fail.
Differential Revision: D88797233