Skip to content

Conversation

@amirafzali
Copy link
Member

Summary: Quick cleanup, move comms related logic to their own modules

Differential Revision: D88219140

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 8, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 8, 2025

@amirafzali has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88219140.

amirafzali added a commit to amirafzali/torchstore that referenced this pull request Dec 8, 2025
Summary:

Quick cleanup, move comms related logic to their own modules

Differential Revision: D88219140
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 41.22807% with 134 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@504b4af). Learn more about missing BASE report.

Files with missing lines Patch % Lines
torchstore/transport/torchcomms/buffer.py 22.47% 69 Missing ⚠️
torchstore/transport/pipe.py 17.39% 19 Missing ⚠️
torchstore/transport/torchcomms/cache.py 60.41% 19 Missing ⚠️
torchstore/transport/buffers.py 62.06% 11 Missing ⚠️
torchstore/client.py 33.33% 8 Missing ⚠️
torchstore/strategy.py 61.53% 5 Missing ⚠️
torchstore/storage_volume.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage        ?   51.15%           
=======================================
  Files           ?       25           
  Lines           ?     2074           
  Branches        ?        0           
=======================================
  Hits            ?     1061           
  Misses          ?     1013           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

amirafzali added a commit to amirafzali/torchstore that referenced this pull request Dec 8, 2025
Summary:

Quick cleanup, move comms related logic to their own modules

Differential Revision: D88219140
amirafzali added a commit to amirafzali/torchstore that referenced this pull request Dec 11, 2025
Summary:

Quick cleanup, move comms related logic to their own modules

Reviewed By: LucasLLC

Differential Revision: D88219140
amirafzali added a commit to amirafzali/torchstore that referenced this pull request Dec 11, 2025
Summary:

Quick cleanup, move comms related logic to their own modules

Reviewed By: LucasLLC

Differential Revision: D88219140
@amirafzali
Copy link
Member Author

Coverage report isn't accurate since GPU tests are disabled in git CI

Summary:

Quick cleanup, move comms related logic to their own modules

Reviewed By: LucasLLC

Differential Revision: D88219140
@meta-codesync meta-codesync bot merged commit 913129a into meta-pytorch:main Dec 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants