Skip to content

Conversation

@amirafzali
Copy link
Member

@amirafzali amirafzali commented Nov 25, 2025

Adds a transport buffer implementation using torchcomms rdma

Differential Revision: D87804516

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 25, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 25, 2025

@amirafzali has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87804516.

amirafzali added a commit to amirafzali/torchstore that referenced this pull request Dec 8, 2025
Summary:
- Adds an implementation for torchcomms rdma transport buffer


Differential Revision: D87804516
amirafzali added a commit to amirafzali/torchstore that referenced this pull request Dec 8, 2025
Summary:
- Adds an implementation for torchcomms rdma transport buffer


Differential Revision: D87804516
amirafzali added a commit to amirafzali/torchstore that referenced this pull request Dec 8, 2025
Summary:
- Adds an implementation for torchcomms rdma transport buffer


Differential Revision: D87804516
amirafzali added a commit to amirafzali/torchstore that referenced this pull request Dec 8, 2025
Summary:
- Adds an implementation for torchcomms rdma transport buffer


Differential Revision: D87804516
amirafzali added a commit to amirafzali/torchstore that referenced this pull request Dec 8, 2025
Summary:
- Adds an implementation for torchcomms rdma transport buffer


Differential Revision: D87804516
amirafzali added a commit to amirafzali/torchstore that referenced this pull request Dec 8, 2025
Summary:
- Adds an implementation for torchcomms rdma transport buffer


Differential Revision: D87804516
amirafzali added a commit to amirafzali/torchstore that referenced this pull request Dec 8, 2025
Summary:
- Adds an implementation for torchcomms rdma transport buffer


Differential Revision: D87804516
amirafzali added a commit to amirafzali/torchstore that referenced this pull request Dec 8, 2025
Summary:
- Adds an implementation for torchcomms rdma transport buffer

Pull Request resolved: meta-pytorch#80

Differential Revision: D87804516
amirafzali added a commit to amirafzali/torchstore that referenced this pull request Dec 8, 2025
Summary:
- Adds an implementation for torchcomms rdma transport buffer


Differential Revision: D87804516
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 37.79904% with 130 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@504b4af). Learn more about missing BASE report.

Files with missing lines Patch % Lines
torchstore/transport/buffers.py 36.24% 95 Missing ⚠️
torchstore/transport/pipe.py 9.52% 19 Missing ⚠️
torchstore/client.py 33.33% 8 Missing ⚠️
torchstore/strategy.py 61.53% 5 Missing ⚠️
torchstore/storage_volume.py 78.57% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage        ?   50.90%           
=======================================
  Files           ?       23           
  Lines           ?     2055           
  Branches        ?        0           
=======================================
  Hits            ?     1046           
  Misses          ?     1009           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

amirafzali added a commit to amirafzali/torchstore that referenced this pull request Dec 8, 2025
Summary:
- Adds an implementation for torchcomms rdma transport buffer


Differential Revision: D87804516
amirafzali added a commit to amirafzali/torchstore that referenced this pull request Dec 11, 2025
Summary:
- Adds an implementation for torchcomms rdma transport buffer


Reviewed By: LucasLLC

Differential Revision: D87804516
amirafzali added a commit to amirafzali/torchstore that referenced this pull request Dec 11, 2025
Summary:
- Adds an implementation for torchcomms rdma transport buffer


Reviewed By: LucasLLC

Differential Revision: D87804516
amirafzali added a commit to amirafzali/torchstore that referenced this pull request Dec 11, 2025
Summary:
- Adds an implementation for torchcomms rdma transport buffer


Reviewed By: LucasLLC

Differential Revision: D87804516
@amirafzali
Copy link
Member Author

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #80   +/-   ##
=======================================
  Coverage        ?   50.90%           
=======================================
  Files           ?       23           
  Lines           ?     2055           
  Branches        ?        0           
=======================================
  Hits            ?     1046           
  Misses          ?     1009           
  Partials        ?        0           

Coverage report isn't accurate since GPU tests are disabled in git CI

Summary:
- Adds an implementation for torchcomms rdma transport buffer


Reviewed By: LucasLLC

Differential Revision: D87804516
@meta-codesync meta-codesync bot merged commit db6b114 into meta-pytorch:main Dec 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants