Fix address history tx ordering #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junderw
approved these changes
Feb 28, 2025
Member
junderw
left a comment
junderw
left a comment
There was a problem hiding this comment.
LGTM
I fixed fmt and clippy.
I checked all the usages of the touched functions to see if we're missing something. It looks like we aren't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REINDEX NOT REQUIRED
Some of the fancy rayon parallelization stuff in 2fbb017 broke the expected ordering of results returned by
lookup_txns, sincepar_bridgedoes not guarantee order is preserved.This causes transactions from
/address/.../txsand/addresses/txsendpoints to be returned in non-deterministic order.The actual pagination is still correct, since the order gets scrambled after we find the correct set of transactions to return, although it's now not always possible to tell which transaction to use for the
after_txidparam for the next page.This PR implements a simple fix by modifying
lookup_txnsand associated methods to includetx_positionas well asblockidfor each transaction in the results, and then uses that data to explicitly re-sort the final results before they are returned.