Skip to content

Fix summary #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wiz merged 1 commit into from
Dec 13, 2024
Merged

Fix summary #109

wiz merged 1 commit into from
Dec 13, 2024

Conversation

@junderw
Copy link
Member

@junderw junderw commented Dec 6, 2024

The summary endpoint wasn't filtering out duplicates.

@junderw junderw requested a review from mononaut December 6, 2024 11:19
mononaut
mononaut approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@mononaut mononaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK @ [0bc5509]

I couldn't find an address where the duplicates issue reproduced locally, but the code looks good and it runs fine.

@wiz wiz merged commit 89f0735 into mempool Dec 13, 2024
7 checks passed
@wiz wiz deleted the junderw/fix-summaries branch December 13, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mononaut mononaut mononaut approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@junderw @mononaut @wiz